Conversation
hirosassa
force-pushed
the
fix-ci-as-uv-way
branch
from
e1e9d2e to
fc89191
Compare
hirosassa
commented
Apr 27, 2025
| ignore_missing_imports = true | ||
|
|
||
| [tool.uv] | ||
| dev-dependencies = [ |
Contributor
Author
There was a problem hiding this comment.
dev-dependencies will be deprecated in the future.
Changed it to dependency-groups.
https://docs.astral.sh/uv/concepts/projects/dependencies/#development-dependencies
Comment on lines
+22
to
+24
| # uv | ||
| COPY --from=ghcr.io/astral-sh/uv:0.6.17 /uv /uvx /bin/ | ||
|
|
Contributor
Author
There was a problem hiding this comment.
himkt
requested changes
Apr 28, 2025
Owner
himkt
left a comment
himkt
left a comment
There was a problem hiding this comment.
Thank you so much @hirosassa for making the project management more sophisticated! I've just learned several stuffs in uv (deprecation, and practice for building a project on docker image build).
I put several requests, could you please take a look?
| max-parallel: 4 | ||
| matrix: | ||
| python-version: ["3.9", "3.10", "3.11"] | ||
| python-version: ["3.9", "3.10", "3.11", "3.12"] |
Comment on lines
+42
to
+45
| RUN --mount=type=cache,target=/root/.cache/uv \ | ||
| --mount=type=bind,source=uv.lock,target=uv.lock \ | ||
| --mount=type=bind,source=pyproject.toml,target=pyproject.toml \ | ||
| uv sync --frozen --no-install-project --no-dev |
Owner
There was a problem hiding this comment.
I didn't know this practice. 📝
Co-authored-by: himkt <himkt@klis.tsukuba.ac.jp>
Co-authored-by: himkt <himkt@klis.tsukuba.ac.jp>
Co-authored-by: himkt <himkt@klis.tsukuba.ac.jp>
himkt
approved these changes
Apr 28, 2025
Owner
himkt
left a comment
himkt
left a comment
There was a problem hiding this comment.
Again, thank you for the contribution!
Contributor
Author
|
Thank you for your quick response! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thank you for creating such a great tool!
In this PR, I simplified CI using
uvfeatures.Please check!